Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stax removal from source tree #87

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Stax removal from source tree #87

wants to merge 5 commits into from

Conversation

leginee
Copy link
Contributor

@leginee leginee commented Jun 7, 2020

As suggested in the Discussion on dev, I have created a patch that removes Stax.

also see Bug 128383

My testing has been so for:

  • a successfull build on Linux
  • executed a function in OpenOffice that is affected (see bug comment 3)

@DamjanJovanovic
Copy link
Contributor

There's a dependency from filter -> saxon -> stax

$ grep SAXON filter -R
filter/prj/build.lst:fl      filter  :    L10N:l10n svtools unotools xmloff cppu tools cppuhelper sal svx javaunohelper jvmaccess canvas SAXON:saxon LIBXSLT:libxslt basegfx NULL
filter/source/xsltfilter/makefile.mk:.IF "$(DISABLE_SAXON)" == ""
filter/source/xsltfilter/makefile.mk:.IF "$(SYSTEM_SAXON)" == "YES"
filter/source/xsltfilter/makefile.mk:XCLASSPATH:=$(XCLASSPATH)$(PATH_SEPERATOR)$(SAXON_JAR)

Apparently the xsltfilter uses it. Not sure where xsltfilter is used but maybe this helps:
https://wiki.openoffice.org/wiki/Documentation/DevGuide/OfficeDev/Integrating_Import_and_Export_Filters

@leginee
Copy link
Contributor Author

leginee commented Jun 7, 2020

Yes that is correct. Let me Quote Pedro Giffuni from the discussion:

While looking for candidates to remove stuff, consider stax. It is
included in Java since JDK5.

So I tried if something breaks. XSLTFILTER is used only in the MS Docuxment import I think, so I loaded a document with my testbuild of AOO and did so far not find any issues.

@LifeCANvs LifeCANvs mentioned this pull request Jun 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leginee @DamjanJovanovic